Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: refactor MAVLink command queue #1546

Merged
merged 3 commits into from
Sep 14, 2021
Merged

core: refactor MAVLink command queue #1546

merged 3 commits into from
Sep 14, 2021

Conversation

julianoes
Copy link
Collaborator

This changes the command queue, so that:

  • Only one queue is required instead of a queue and a sent map
  • SET_MESSAGE_INTERVAL (511) and REQUEST_MESSAGE (512) commands are only denied if also param1 (msgid) match, otherwise they are kept in the queue until later. This should help with initial requests of messages.

JonasVautherin
JonasVautherin previously approved these changes Sep 13, 2021
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

Base automatically changed from pr-fix-commands to main September 14, 2021 05:31
julianoes and others added 3 commits September 14, 2021 07:36
This changes the command queue, so that:
- Only one queue is required instead of a queue and a sent map
- SET_MESSAGE_INTERVAL (511) and REQUEST_MESSAGE (512) commands are only
  denied if also param1 (msgid) match, otherwise they are kept in the
  queue until later. This should help with initial requests of messages.
This way the comparison is easy later.std::round
@julianoes julianoes marked this pull request as ready for review September 14, 2021 05:45
@julianoes julianoes merged commit ff986d8 into main Sep 14, 2021
@julianoes julianoes deleted the pr-one-command-queue branch September 14, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants